[PATCH] D51211: [Sema] Emit -Wformat properly for bitfield promotions.
Bevin Hansson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 18 00:26:22 PST 2018
ebevhan marked an inline comment as done.
ebevhan added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:7725-7726
+ return true;
+ // Look through vector types, since we do default argument promotion for
+ // those in OpenCL.
+ if (const ExtVectorType *VecTy = From->getAs<ExtVectorType>())
> Looking at `Sema::DefaultArgumentPromotion()`, it seems there is some special logic there for _Float16 vs half/fp16. Do we need to deal with that here as well?
I think it should be fine. If the special handling of those don't take, there won't be a default promotion for them, so this routine won't care about it.
CHANGES SINCE LAST ACTION
More information about the cfe-commits