[PATCH] D55616: Emit ASM input in a constant context

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 17 17:36:37 PST 2018

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM with a minor nit, but give a couple days for @jyknight to add any more comments.

Comment at: test/CodeGen/builtin-constant-p.c:2
+// RUN: %clang_cc1 -triple x86_64-unknown-unknown -emit-llvm -o - %s -O2 | FileCheck --check-prefix=O2 %s
+// RUN: %clang_cc1 -triple x86_64-unknown-unknown -emit-llvm -o - %s -O0 | FileCheck --check-prefix=O0 %s
void wrote:
> efriedma wrote:
> > Given this code doesn't check the optimization level anymore, do you still need separate check prefixes for `O2` and `O0`.  Or if that doesn't work for everything, maybe you could share a check prefix for some of the tests? (Maybe it would make sense to check IR generated using `-disable-llvm-passes`.)
> The bug only triggered at `O0`, so I still want to test it without optimizations. Note that we do check optimization levels during code generation to determine if we should generate an `is.constant` intrinsic.
You can use something like "-check-prefixes=CHECK,O0" to reduce the duplication.

  rC Clang



More information about the cfe-commits mailing list