[PATCH] D55770: [clangd] BackgroundIndex rebuilds symbol index periodically.

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 17 09:43:52 PST 2018


kadircet added inline comments.


================
Comment at: clangd/index/Background.cpp:464
+  if (BuildIndexPeriodMs > 0)
+    SymbolsUpdatedSinceLastIndex = true;
+  else
----------------
why not simply check if `BuildIndexPeriodMs` has passed and issue rebuild here? That way we won't spawn an additional thread, and get rid of the CV


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55770/new/

https://reviews.llvm.org/D55770





More information about the cfe-commits mailing list