[PATCH] D38675: [analyzer] MoveChecker Pt.10: Move the checker out of alpha state.

Sun Dec 16 22:28:01 PST 2018

NoQ added a comment.

Currently the checker is very quiet. I have seen exactly 6 warnings on internal codebases on which i tested it (on which we otherwise emit around 12000 warnings), and all of them were good. The only false positive i've seen so far was fixed in D55566 <https://reviews.llvm.org/D55566>.

We might find more problems with liveness analysis being too conservative, but i'm not seeing many of them right now.

We might also come to a conclusion that the local variable heuristic is not that good, but we have an option to quickly turn it off by flipping a flag introduced in D55730 <https://reviews.llvm.org/D55730>.

So i think this is safe to enable.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D38675/new/

https://reviews.llvm.org/D38675