[PATCH] D54918: [analyzer] Apply clang-format to GenericTaintChecker.cpp

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Dec 15 02:30:22 PST 2018


Szelethus added a comment.

Please don't mind me intruding.
If you create a patch for the Clang Static Analyzer, please add "[analyzer]" in the revision title, because many of us are automatically subscribed to those patches. Also, upload patches with full context.
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

I see the point here, and I think it'd be worth to just clang-format most of the files we work with, as the benefits would outweigh the drawbacks (at least eventually...), but I vaguely remember @george.karpenkov having many great points against it -- please don't commit until he can take a look :)


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54918/new/

https://reviews.llvm.org/D54918





More information about the cfe-commits mailing list