[PATCH] D55363: [clangd] Expose FileStatus in LSP.

Simon Marchi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 14 09:14:04 PST 2018


simark added a comment.

In D55363#1329652 <https://reviews.llvm.org/D55363#1329652>, @ilya-biryukov wrote:

> Sorry if I missed any important design discussions here, but wanted to clear up what information we are trying to convey to the user with the status messages?
>  E.g. why seeing "building preamble", "building file" or "queued" in the status bar can be useful to the user? Those messages mention internals of clangd, I'm not sure how someone unfamiliar with internals of clangd should interpret this information.


I agree about not necessarily needing to expose clang internals, but I think the end goal of providing some feedback to the user (still thinking/done) is worthy.

If this is a clangd-specific event, shouldn't the name of the event reflect it?  As-is, it looks like an official LSP feature and can be confusing.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55363/new/

https://reviews.llvm.org/D55363





More information about the cfe-commits mailing list