[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

[Scott Linder via Phabricator via cfe-commits]

scott.linder added a comment.

In D54489#1330255 <https://reviews.llvm.org/D54489#1330255>, @rjmccall wrote:

> So we're using the same command line option as GCC to produce something in the same section as GCC but formatting that section incompatibly with GCC?  That combination of choices does not seem like a good idea.


>From the GCC man page -frecord-gcc-switches "is only implemented on some targets and the exact format of the recording is target and binary file format dependent, but it usually takes the form of a section containing ASCII text"

In the LLVM portion of this review it was decided that the implications of this is that well-behaved consumers should not make assumptions about the format. They should also not make assumptions about the name of the section, but we are effectively backwards-compatible in that we are a section with ASCII text, so tools which just e.g. dump the section for uses will continue to work with our implementation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54489/new/

https://reviews.llvm.org/D54489