[PATCH] D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 13 12:04:29 PST 2018


lebedev.ri added inline comments.


================
Comment at: clang-tidy/plugin/ClangTidyPlugin.cpp:11
 #include "../ClangTidy.h"
+#include "../ClangTidyForceLinker.h"
 #include "../ClangTidyModule.h"
----------------
yvvan wrote:
> It seems it had to go after #include "clang/Config/config.h" to have MPI checks enabled...
The includes should be auto-sorted by clang-format, so if that header needs some headers,
then it should include them, not hope they will already be included.



Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55595/new/

https://reviews.llvm.org/D55595





More information about the cfe-commits mailing list