[PATCH] D55044: [clang-tidy] check for Abseil make_unique

Andy Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 13 11:16:58 PST 2018


axzhang added a comment.

In D55044#1329604 <https://reviews.llvm.org/D55044#1329604>, @hokein wrote:

> In fact, the existing `modernize-make-unique` can be configured to support `absl::make_unique`, you'd just need to configure the check option `MakeSmartPtrFunction` to `absl::make_unique` (this is what we do inside google).
>
> The biggest missing part of the `modernize-make-unique` is `absl::WrapUnique`, I think we should extend `MakeSmartPtrCheck` class (maybe add hooks) to support it.


What is the best way to extend `MakeSmartPtrCheck`? The behavior I want to achieve is that `absl::WrapUnique` is suggested when brace initialization is used, but `absl::make_unique` is used in all other cases.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55044/new/

https://reviews.llvm.org/D55044





More information about the cfe-commits mailing list