r349061 - [CodeComplete] Temporarily disable failing assertion

Ilya Biryukov via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 13 09:23:48 PST 2018


Author: ibiryukov
Date: Thu Dec 13 09:23:48 2018
New Revision: 349061

URL: http://llvm.org/viewvc/llvm-project?rev=349061&view=rev
Log:
[CodeComplete] Temporarily disable failing assertion

Found the case in the clang codebase where the assertion fires.
To avoid crashing assertion-enabled builds before I re-add the missing
operation.
Will restore the assertion alongside the upcoming fix.

Modified:
    cfe/trunk/lib/Sema/SemaCodeComplete.cpp

Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaCodeComplete.cpp?rev=349061&r1=349060&r2=349061&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaCodeComplete.cpp (original)
+++ cfe/trunk/lib/Sema/SemaCodeComplete.cpp Thu Dec 13 09:23:48 2018
@@ -4949,7 +4949,8 @@ static QualType getPreferredTypeOfBinary
   case tok::arrowstar:
     return QualType();
   default:
-    assert(false && "unhandled binary op");
+    // FIXME(ibiryukov): handle the missing op, re-add the assertion.
+    // assert(false && "unhandled binary op");
     return QualType();
   }
 }




More information about the cfe-commits mailing list