r348982 - Revert "Declares __cpu_model as dso local"

Haibo Huang via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 12 14:39:51 PST 2018


Author: hhb
Date: Wed Dec 12 14:39:51 2018
New Revision: 348982

URL: http://llvm.org/viewvc/llvm-project?rev=348982&view=rev
Log:
Revert "Declares __cpu_model as dso local"

This reverts r348978


Modified:
    cfe/trunk/lib/CodeGen/CGBuiltin.cpp
    cfe/trunk/test/CodeGen/builtin-cpu-is.c
    cfe/trunk/test/CodeGen/builtin-cpu-supports.c

Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGBuiltin.cpp?rev=348982&r1=348981&r2=348982&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGBuiltin.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGBuiltin.cpp Wed Dec 12 14:39:51 2018
@@ -9465,7 +9465,6 @@ Value *CodeGenFunction::EmitX86CpuIs(Str
 
   // Grab the global __cpu_model.
   llvm::Constant *CpuModel = CGM.CreateRuntimeVariable(STy, "__cpu_model");
-  cast<llvm::GlobalValue>(CpuModel)->setDSOLocal(true);
 
   // Calculate the index needed to access the correct field based on the
   // range. Also adjust the expected value.
@@ -9538,7 +9537,6 @@ llvm::Value *CodeGenFunction::EmitX86Cpu
 
     // Grab the global __cpu_model.
     llvm::Constant *CpuModel = CGM.CreateRuntimeVariable(STy, "__cpu_model");
-    cast<llvm::GlobalValue>(CpuModel)->setDSOLocal(true);
 
     // Grab the first (0th) element from the field __cpu_features off of the
     // global in the struct STy.
@@ -9558,8 +9556,6 @@ llvm::Value *CodeGenFunction::EmitX86Cpu
   if (Features2 != 0) {
     llvm::Constant *CpuFeatures2 = CGM.CreateRuntimeVariable(Int32Ty,
                                                              "__cpu_features2");
-    cast<llvm::GlobalValue>(CpuFeatures2)->setDSOLocal(true);
-
     Value *Features =
         Builder.CreateAlignedLoad(CpuFeatures2, CharUnits::fromQuantity(4));
 
@@ -9577,7 +9573,6 @@ Value *CodeGenFunction::EmitX86CpuInit()
   llvm::FunctionType *FTy = llvm::FunctionType::get(VoidTy,
                                                     /*Variadic*/ false);
   llvm::Constant *Func = CGM.CreateRuntimeFunction(FTy, "__cpu_indicator_init");
-  cast<llvm::GlobalValue>(Func)->setDSOLocal(true);
   return Builder.CreateCall(Func);
 }
 

Modified: cfe/trunk/test/CodeGen/builtin-cpu-is.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/builtin-cpu-is.c?rev=348982&r1=348981&r2=348982&view=diff
==============================================================================
--- cfe/trunk/test/CodeGen/builtin-cpu-is.c (original)
+++ cfe/trunk/test/CodeGen/builtin-cpu-is.c Wed Dec 12 14:39:51 2018
@@ -4,8 +4,6 @@
 // global, the bit grab, and the icmp correct.
 extern void a(const char *);
 
-// CHECK: @__cpu_model = external dso_local global { i32, i32, i32, [1 x i32] }
-
 void intel() {
   if (__builtin_cpu_is("intel"))
     a("intel");

Modified: cfe/trunk/test/CodeGen/builtin-cpu-supports.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/builtin-cpu-supports.c?rev=348982&r1=348981&r2=348982&view=diff
==============================================================================
--- cfe/trunk/test/CodeGen/builtin-cpu-supports.c (original)
+++ cfe/trunk/test/CodeGen/builtin-cpu-supports.c Wed Dec 12 14:39:51 2018
@@ -4,9 +4,6 @@
 // global, the bit grab, and the icmp correct.
 extern void a(const char *);
 
-// CHECK: @__cpu_model = external dso_local global { i32, i32, i32, [1 x i32] }
-// CHECK: @__cpu_features2 = external dso_local global i32
-
 int main() {
   __builtin_cpu_init();
 
@@ -28,5 +25,3 @@ int main() {
 
   return 0;
 }
-
-// CHECK: declare dso_local void @__cpu_indicator_init()




More information about the cfe-commits mailing list