[PATCH] D55534: [AST] Store "UsesADL" information in CallExpr.

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 11 11:56:41 PST 2018


EricWF marked an inline comment as done.
EricWF added a comment.

I think this is good to go. Any more comments?



================
Comment at: include/clang/Sema/Sema.h:2758
                             bool AllowExplicit = false,
+                            bool IsADLCandidate = false,
                             ConversionSequenceList EarlyConversions = None);
----------------
EricWF wrote:
> rsmith wrote:
> > Long lists of bool arguments make me nervous, especially with default arguments. Can you introduce an enum for the new param at least?
> Ack. I was thinking the same thing. 
And you were right to be nervous. The change found bugs.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55534/new/

https://reviews.llvm.org/D55534





More information about the cfe-commits mailing list