[PATCH] D55413: [ExprConstant] Handle compound assignment when LHS has integral type and RHS has floating point type

S. B. Tam via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 11 08:23:56 PST 2018


cpplearner marked an inline comment as done.
cpplearner added inline comments.


================
Comment at: clang/test/SemaCXX/constant-expression-cxx1y.cpp:343
     if (a != 7) return false;
-    a *= 3;
     if (a != 21) return false;
----------------
riccibruno wrote:
> Why remove `a *= 3` instead of just adding `a *= 3.1`.
Because adding `a *= 3.1` here will change the result of the whole calculation?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55413/new/

https://reviews.llvm.org/D55413





More information about the cfe-commits mailing list