[PATCH] D55428: [Docs] Expand -fstack-protector and -fstack-protector-all info

Thomas Preud'homme via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 11 05:16:13 PST 2018


thopre added inline comments.


================
Comment at: include/clang/Driver/Options.td:1636
 def fstack_protector_all : Flag<["-"], "fstack-protector-all">, Group<f_Group>,
   HelpText<"Force the usage of stack protectors for all functions">;
 def fstack_protector_strong : Flag<["-"], "fstack-protector-strong">, Group<f_Group>,
----------------
May I suggest to change it to "Enable stack protectors for all functions" for consistency with below entries? Rest LGTM otherwise.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55428/new/

https://reviews.llvm.org/D55428





More information about the cfe-commits mailing list