[PATCH] D54450: Get the correct range of tokens for preprocessor conditions

Mon Dec 10 07:31:35 PST 2018

aaron.ballman added inline comments.

================
Comment at: lib/Lex/PPExpressions.cpp:154-156
     // Consume the ).
-    Result.setEnd(PeekTok.getLocation());
     PP.LexNonComment(PeekTok);
+    Result.setEnd(PeekTok.getLocation());
----------------
lebedev.ri wrote:
> I'm not sure this is covered with the test?
The tests for that were attached as a file rather than a separate patch. Basically, this change is needed to keep the behavior the same for tools like pp-trace and modularize. However, I have added new unit tests that demonstrate the behavior.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54450/new/

https://reviews.llvm.org/D54450