[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added a comment.

In D55433#1323779 <https://reviews.llvm.org/D55433#1323779>, @lebedev.ri wrote:

> In D55433#1323757 <https://reviews.llvm.org/D55433#1323757>, @MyDeveloperDay wrote:
>
> > a lot of projects aren't setup for c++17 yet which is needed for [[nodiscard]] to be allowed,
>
>
> You can use `[[clang::warn_unused_result]]` for this evaluation, that does not require C++17.
>
> > But the clang-tidy -fix doesn't break the build, the patch is large but nothing broke. (at compile time at least!)
> > 
> >   {F7661182} 
>
> Uhm, so there wasn't a single true-positive in protobuf?


To elaborate, what i'm asking is:

- Is that project -Werror clean without those changes?
- if yes, after all those changes, does the -Werror build break?
  - If it does break, how many of those issues are actual bugs (ignored return when it should not be ignored), and how many are noise.
  - If not, then i guess all these were "false-positives"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55433/new/

https://reviews.llvm.org/D55433