[PATCH] D55393: Re-order content of template parameter dumps

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Dec 9 09:21:03 PST 2018


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from some minor nits



================
Comment at: lib/AST/ASTDumper.cpp:106
+                                 const Decl *From = nullptr,
+                                 const char *label = nullptr);
     void dumpTemplateArgumentList(const TemplateArgumentList &TAL);
----------------
s/label/Label per naming conventions (same below).


================
Comment at: lib/AST/ASTDumper.cpp:733
 
+    if (From) {
+      dumpDeclRef(From, label);
----------------
Elide braces.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55393/new/

https://reviews.llvm.org/D55393





More information about the cfe-commits mailing list