[PATCH] D55395: Re-order content in OMPDeclareReductionDecl dump

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Dec 9 09:01:22 PST 2018


aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM with a small nit. @ABataev, are you okay with this approach?



================
Comment at: lib/AST/ASTDumper.cpp:1060
+  dumpStmt(D->getCombiner());
+  if (auto *Initializer = D->getInitializer()) {
     dumpStmt(Initializer);
----------------
Elide braces and may as well make this `const auto *`. (If you want to hit the one above, that would also be good -- maybe even hoist the call into an initializer for a local variable to be used in both places?)


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55395/new/

https://reviews.llvm.org/D55395





More information about the cfe-commits mailing list