[PATCH] D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 📙

Stephane Moore via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Dec 8 19:44:03 PST 2018


stephanemoore created this revision.
stephanemoore added reviewers: benhamilton, aaron.ballman.
Herald added subscribers: cfe-commits, xazax.hun.

The diagnostics from google-objc-function-naming check will be more
actionable if they provide a brief description of the requirements from
the Google Objective-C style guide. The more descriptive diagnostics may
help clarify that functions in the global namespace must have an
appropriate prefix followed by Pascal case (engineers working previously
with static functions might not immediately understand the different
requirements of static and non-static functions).

Test Notes:
Verified against the clang-tidy tests.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D55482

Files:
  clang-tidy/google/FunctionNamingCheck.cpp
  test/clang-tidy/google-objc-function-naming.m
  test/clang-tidy/google-objc-function-naming.mm

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55482.177403.patch
Type: text/x-patch
Size: 6424 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181209/8baf0d3c/attachment-0001.bin>


More information about the cfe-commits mailing list