[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 7 14:23:18 PST 2018


Eugene.Zelenko added inline comments.


================
Comment at: docs/ReleaseNotes.rst:173
+
+  This check adds ``[[nodiscard]]`` attributes (introduced in C++17) to member
+  functions to highlight at compile time where the return value of a function
----------------
Please omit this check. Same in documentation.


================
Comment at: docs/ReleaseNotes.rst:175
+  functions to highlight at compile time where the return value of a function
+  should not be ignored
+
----------------
Please add dot at the end.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55433/new/

https://reviews.llvm.org/D55433





More information about the cfe-commits mailing list