[PATCH] D55456: [CUDA] added missing 'inline' for the functions defined in the header.

Justin Lebar via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 7 13:58:09 PST 2018


Lgtm

On Fri, Dec 7, 2018, 1:12 PM Artem Belevich via Phabricator <
reviews at reviews.llvm.org> wrote:

> tra created this revision.
> tra added a reviewer: jlebar.
> Herald added subscribers: bixia, sanjoy.
>
> https://reviews.llvm.org/D55456
>
> Files:
>   clang/lib/Headers/cuda_wrappers/new
>
>
> Index: clang/lib/Headers/cuda_wrappers/new
> ===================================================================
> --- clang/lib/Headers/cuda_wrappers/new
> +++ clang/lib/Headers/cuda_wrappers/new
> @@ -73,10 +73,12 @@
>
>  // Sized delete, C++14 only.
>  #if __cplusplus >= 201402L
> -__device__ void operator delete(void *ptr, __SIZE_TYPE__ size)
> CUDA_NOEXCEPT {
> +__device__ inline void operator delete(void *ptr,
> +                                       __SIZE_TYPE__ size) CUDA_NOEXCEPT {
>    ::operator delete(ptr);
>  }
> -__device__ void operator delete[](void *ptr, __SIZE_TYPE__ size)
> CUDA_NOEXCEPT {
> +__device__ inline void operator delete[](void *ptr,
> +                                         __SIZE_TYPE__ size)
> CUDA_NOEXCEPT {
>    ::operator delete(ptr);
>  }
>  #endif
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181207/f5b897ab/attachment.html>


More information about the cfe-commits mailing list