[PATCH] D55443: [test] Capture stderr from 'tar --version' call as well

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 7 09:52:08 PST 2018


MaskRay added inline comments.


================
Comment at: test/lit.cfg.py:99
+        stdout=subprocess.PIPE,
+        stderr=subprocess.PIPE,
+        env={'LANG': 'C'})
----------------
If you don't need stderr, remove `stderr=subprocess.PIPE,`

`subprocess.Popen followed by communicate()` can be replaced by `check_output`

`if 'GNU tar' in sout:` does not in Python 3 as `sout` would have type `bytes`, not `str`


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55443/new/

https://reviews.llvm.org/D55443





More information about the cfe-commits mailing list