[PATCH] D55415: Revert removal of tidy plugin support from libclang

Ivan Donchevskii via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 7 07:15:41 PST 2018


yvvan added a comment.

In D55415#1323120 <https://reviews.llvm.org/D55415#1323120>, @bkramer wrote:

> I'd be interested in hearing how this is used. I added this feature as an experiment a while back but it simply didn't work as I envisioned it to. Some checks do work but the overall latency makes it unusable in an IDE setting. People repeatedly asked me to remove it because it slows down builds while not adding value.


We use it with Qt Creator and you can see that we make additions/fixes in libclang from time to time.
With tidy checks selected it is slow indeed but there's always a choice whether to enable checks or not. And if you have very few checks enabled it performs quite fine. And we are still using libclang because we already have infrastructure on top of it which can't be just replaced with clangd (at least it requires quite some time).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55415/new/

https://reviews.llvm.org/D55415





More information about the cfe-commits mailing list