[PATCH] D55245: [clang-tidy] Add the abseil-duration-subtraction check

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added subscribers: astrelni, ahedberg.
hokein added a comment.
This revision is now accepted and ready to land.

The check looks good from my side, except one nit.

> I assume I've got the right reviewers here, but I've also been sending a bunch of stuff your way lately, so if I'm overwhelming review capacity, please let me know.

I think in long run, it would be desired to have Abseil experts participate in reviews of abseil-related checks (upstream clang-tidy reviewers don't have much knowledge about Abseil). Abseil team members (@astrelni, @ahedberg) might be more interested in theses checks which could accelerate the review process.



================
Comment at: test/clang-tidy/abseil-duration-subtraction.cpp:4
+// Mimic the implementation of absl::Duration
+namespace absl {
+
----------------
We have multiple implementations in other `abseil-duration-*` tests, I think we could pull them out (in `test/clang-tidy/Inputs/absl/time/time.h`).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55245/new/

https://reviews.llvm.org/D55245