[clang-tools-extra] r348490 - [clangd] Remove the test that sometimes deadlocks

Ilya Biryukov via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 6 07:14:11 PST 2018


Author: ibiryukov
Date: Thu Dec  6 07:14:11 2018
New Revision: 348490

URL: http://llvm.org/viewvc/llvm-project?rev=348490&view=rev
Log:
[clangd] Remove the test that sometimes deadlocks

Will figure out how to properly rewrite it and recommit.

Modified:
    clang-tools-extra/trunk/unittests/clangd/TUSchedulerTests.cpp

Modified: clang-tools-extra/trunk/unittests/clangd/TUSchedulerTests.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/unittests/clangd/TUSchedulerTests.cpp?rev=348490&r1=348489&r2=348490&view=diff
==============================================================================
--- clang-tools-extra/trunk/unittests/clangd/TUSchedulerTests.cpp (original)
+++ clang-tools-extra/trunk/unittests/clangd/TUSchedulerTests.cpp Thu Dec  6 07:14:11 2018
@@ -709,29 +709,6 @@ TEST_F(TUSchedulerTests, TUStatus) {
                   TUState(TUAction::Idle, /*No action*/ "")));
 }
 
-TEST_F(TUSchedulerTests, NoTUStatusEmittedForRemovedFile) {
-  class CaptureTUStatus : public DiagnosticsConsumer {
-  public:
-    void onDiagnosticsReady(PathRef File,
-                            std::vector<Diag> Diagnostics) override {}
-
-    void onFileUpdated(PathRef File, const TUStatus &Status) override {
-      // Block the worker thread until the document is removed.
-      Removed.wait();
-    }
-    Notification Removed;
-  } CaptureTUStatus;
-  MockFSProvider FS;
-  MockCompilationDatabase CDB;
-  ClangdServer Server(CDB, FS, CaptureTUStatus, ClangdServer::optsForTest());
-
-  Server.addDocument(testPath("foo.cpp"), "int main() {}",
-                     WantDiagnostics::Yes);
-  Server.removeDocument(testPath("foo.cpp"));
-  CaptureTUStatus.Removed.notify();
-  ASSERT_TRUE(Server.blockUntilIdleForTest()) << "Waiting for finishing";
-}
-
 } // namespace
 } // namespace clangd
 } // namespace clang




More information about the cfe-commits mailing list