[PATCH] D53280: [analyzer] Emit an error for invalid -analyzer-config inputs

[Kristóf Umann via Phabricator via cfe-commits]

Szelethus added a comment.

In D53280#1319446 <https://reviews.llvm.org/D53280#1319446>, @NoQ wrote:

> Ugh. We broke backwards compatibility when an invalid `-analyzer-config` is specified but `-analyze` isn't specified. Yes, people are accidentally relying on that :/ :/ :/
>
> In this case the driver doesn't know that it needs to add `analyzer-config-compatibility-mode=true` (or, even better, outright ignore all analyzer options) but the frontend doesn't know that it doesn't need to parse them.


Oh my god. Can you go a little more in depth? Was the problem something along the lines of `treu` typo, or a non-existent flag? Is that at all salvageable? I mean, losing the entire patch would be super bad imo.

Also, I can't attend to this issue immediately -- replying on the phone is one thing, but almost any other action is out of my reach for the next couple days/weeks.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53280/new/

https://reviews.llvm.org/D53280