[PATCH] D55289: [analyzer] MoveChecker Pt.5: Improve invalidation policies.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 4 12:14:08 PST 2018


NoQ added inline comments.


================
Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:545
+      if (ThisRegion != Region)
+        if (std::find(Regions.begin(), Regions.end(), Region) != Regions.end())
+          State = removeFromState(State, Region);
----------------
This is clumsy. I think we shouldn't include non-invalidated regions in the `ExplicitRegions` array in the first place.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55289/new/

https://reviews.llvm.org/D55289





More information about the cfe-commits mailing list