[PATCH] D55136: [OpenCL][Sema] Improve BuildResolvedCallExpr handling of builtins

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 3 02:26:01 PST 2018


Anastasia added inline comments.


================
Comment at: lib/Sema/SemaExpr.cpp:5556
     // Extract the return type from the (builtin) function pointer type.
-    auto FnPtrTy = Context.getPointerType(FDecl->getType());
+    // FIXME Several builtins still have setType in Sema::CheckBuiltinFunctionCall.
+    //       One should review their definitions in Builtins.def to ensure they
----------------
riccibruno wrote:
> This goes over 80 cols.
I think the format is normally
  // FIXME: text...
  // more text...
No extra spaces on the next line. :)



Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55136/new/

https://reviews.llvm.org/D55136





More information about the cfe-commits mailing list