[PATCH] D55136: [OpenCL][Sema] Improve BuildResolvedCallExpr handling of builtins

[Bruno Ricci via Phabricator via cfe-commits]

riccibruno accepted this revision.
riccibruno added a comment.
This revision is now accepted and ready to land.

Much better. LGTM with a small format nit.



================
Comment at: lib/Sema/SemaExpr.cpp:5556
     // Extract the return type from the (builtin) function pointer type.
-    auto FnPtrTy = Context.getPointerType(FDecl->getType());
+    // FIXME Several builtins still have setType in Sema::CheckBuiltinFunctionCall.
+    //       One should review their definitions in Builtins.def to ensure they
----------------
This goes over 80 cols.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55136/new/

https://reviews.llvm.org/D55136