[PATCH] D55139: [clangd] Avoid memory-mapping files on Windows

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 30 11:50:20 PST 2018


ilya-biryukov created this revision.
ilya-biryukov added reviewers: hokein, kadircet.
Herald added subscribers: arphaman, jkorous, MaskRay, ioeric, mgorny.

Memory-mapping files on Windows leads to them being locked and prevents
editors from saving changes to those files on disk. This is fine for the
compiler, but not acceptable for an interactive tool like clangd.
Therefore, we choose to avoid using memory-mapped files on Windows.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D55139

Files:
  clangd/CMakeLists.txt
  clangd/FSProvider.cpp
  clangd/FSProvider.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55139.176176.patch
Type: text/x-patch
Size: 3441 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181130/12870b37/attachment.bin>


More information about the cfe-commits mailing list