[PATCH] D55134: [CTU] Add triple/lang mismatch handling

[Umann Kristóf via Phabricator via cfe-commits]

Szelethus added a comment.

Hah. Do we support CTU for other languages, like ObjC and ObjC++? Can this be an issue there?



================
Comment at: lib/CrossTU/CrossTranslationUnit.cpp:59
+}
+}
+
----------------
`// end of namespace llvm`


================
Comment at: lib/CrossTU/CrossTranslationUnit.cpp:210
+  if (!hasEqualKnownFields(TripleTo, TripleFrom)) {
+    // TODO pass the SourceLocation of the CallExpression for more precise
+    // diagnostics
----------------
`TODO: `


================
Comment at: lib/CrossTU/CrossTranslationUnit.cpp:214
+        << Unit->getMainFileName() << TripleTo.str() << TripleFrom.str();
+    // TODO Add statistics here
+    return llvm::make_error<IndexError>(index_error_code::triple_mismatch);
----------------
Use punctuation.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55134/new/

https://reviews.llvm.org/D55134