[PATCH] D55121: Make several Python scripts portable across Python2 and Python 3

Michael Platings via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 30 07:58:23 PST 2018


michaelplatings added a comment.

In general LGTM, as someone who's done a 2-3 conversion of similar scale before.

The only suggestion I'd make is to consider changing the `__future__` imports to `from __future__ import absolute_import, division, print_function`
I found this gave the best consistency between 2 & 3. Probably you don't need it at this point, but once the conversion is done there's less to go wrong in future.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55121/new/

https://reviews.llvm.org/D55121





More information about the cfe-commits mailing list