[PATCH] D55069: Extend the CommentVisitor with parameter types

Fri Nov 30 06:10:51 PST 2018

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

In D55069#1314508 <https://reviews.llvm.org/D55069#1314508>, @steveire wrote:

> > Huh, that's surprising. It's a perfect forwarding reference
>
> It's not a forwarding reference because the template parameter is from the record, not the function. See
>
>   https://godbolt.org/z/L4N2aS

Ah, you're exactly right! I hadn't picked up on that.

>> One of the reasons I think this may be important is with the JSON dumper -- it may pass around JSON values rather than references and rely on move semantics to make this work.
> 
> I don't know what you're planning so I can't imagine what you want to pass through these visit function parameters. It would be surprising to me if you used this feature of the visitor for json dumping.

It can be dealt with if/when it arises.

LGTM!

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55069/new/

https://reviews.llvm.org/D55069