[PATCH] D55062: [clangd] Partition include graph on auto-index.

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 30 04:44:50 PST 2018


kadircet added inline comments.


================
Comment at: unittests/clangd/BackgroundIndexTests.cpp:192
+                        [&](llvm::StringRef) { return &MSS; });
+    CDB.setCompileCommand(testPath("root"), Cmd);
+    ASSERT_TRUE(Idx.blockUntilIdleForTest());
----------------
ilya-biryukov wrote:
> This sets a compile command for a directory. Should it be `"root/A.cc"` or am I missing something?
WOW! Thanks for noticing it :D It was working correctly before because we were deducing the file's absolute path from the compile command itself rather than what we've received by watching the CDB. Changed all references in the file.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55062/new/

https://reviews.llvm.org/D55062





More information about the cfe-commits mailing list