[PATCH] D55061: [clangd] Penalize destructor and overloaded operators in code completion.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 30 03:19:08 PST 2018


ioeric added inline comments.


================
Comment at: clangd/Quality.h:74
     Keyword,
+    Operator,
   } Category = Unknown;
----------------
hokein wrote:
> Maybe name it `OverloadedOperator` to avoid confusion with other non-overloaded operators like `?:`
Ternary operator is not a symbol AFAIK?  It's an expression. Even if it's an operator, I think we would still want to categorize it as operator. 


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55061/new/

https://reviews.llvm.org/D55061





More information about the cfe-commits mailing list