[PATCH] D54013: [analyzer] NFC: MallocChecker: Avoid redundant transitions.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 29 19:55:02 PST 2018


NoQ marked an inline comment as done.
NoQ added inline comments.


================
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2383-2384
 
+  if (RS == OldRS)
+    return;
+
----------------
NoQ wrote:
> Szelethus wrote:
> > Hmmm, I guess we return here because if `RegionState` is unchanged, so should be `ReallocPairs` and `FreeReturnValue`, correct?
> Yeah, kinda. Deserves a comment, i guess.
Or even an assertion.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54013/new/

https://reviews.llvm.org/D54013





More information about the cfe-commits mailing list