[PATCH] D55022: OpenCL: Extend argument promotion rules to vector types

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 29 08:46:48 PST 2018


Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.

LGTM! Apart from the test can be changed.



================
Comment at: test/CodeGenOpenCL/printf.cl:2
+// REQUIRES: amdgpu-registered-target
+// RUN: %clang_cc1 -cl-std=CL1.2 -triple amdgcn-unknown-unknown -disable-llvm-passes -emit-llvm -o - %s | FileCheck -check-prefixes=FP64,ALL %s
+// RUN: %clang_cc1 -cl-std=CL1.2 -triple r600-unknown-unknown -disable-llvm-passes -emit-llvm -o - %s | FileCheck -check-prefixes=NOFP64,ALL %s
----------------
I would prefer to test this with spir target since it's not AMD specific. We can use pragma extension enable/disable. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55022/new/

https://reviews.llvm.org/D55022





More information about the cfe-commits mailing list