[PATCH] D55023: OpenCL: Improve vector printf warnings

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 29 08:19:56 PST 2018


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: test/SemaOpenCL/printf-format-strings.cl:65
+{
+    printf("%v4f\n", arg); // expected-warning {{format specifies type 'double __attribute__((ext_vector_type(4)))' but the argument has type 'float2' (vector of 2 'float' values)}}
 }
----------------
arsenm wrote:
> arsenm wrote:
> > Anastasia wrote:
> > > So there is no way to print vector of float? What will happen on architectures that don't support doubles?
> > > 
> > > I guess it's the same for printf in general with the float type?
> > There is, it's converted to a vector of doubles. This case warns because the element count mismatches
> The conversion is to float if doubles aren't supported
The warning message is wrong though without doubles, and still says double.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55023/new/

https://reviews.llvm.org/D55023





More information about the cfe-commits mailing list