[PATCH] D55052: Fix junk output in clangd vscode plugin

[Eric Liu via Phabricator via cfe-commits]

ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.

In D55052#1312766 <https://reviews.llvm.org/D55052#1312766>, @hokein wrote:

> In D55052#1312760 <https://reviews.llvm.org/D55052#1312760>, @ilya-biryukov wrote:
>
> > +1 to the change, this is annoying for me too.
> >
> > In D55052#1312753 <https://reviews.llvm.org/D55052#1312753>, @hokein wrote:
> >
> > > @jfindley I'd like to understand how do these log messages noise you? Does the window prompt up to you automatically (this only happens when there is an error in clangd)? These messages only get print to the  `clangd-vscode` output panel which is used for debugging purposes (normal users won't open this window by their own).
> >
> >
> > It's fine to have this open for debugging purposes, the real problem is that it pops up whenever clangd send an error response. We do this a lot now that we support cancellation and the default policy is to show an output window in that case as well.
>
>
> For cancellation errors, it might be reasonable, but what if other unrecoverable errors in clangd (e.g. clangd crashes), in these cases, users don't know what happens, and would still expect IDE features (like code completion) to work...


FWIW, I think users shouldn't be forced to look at clangd output when they don't want to. If some feature doesn't work as expected, users can still look at the log. Clangd crash should be rare, and even when there are errors, they're usually not interesting/useful for users to look at.  Errors from clangd should not interrupt users' workflow.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55052/new/

https://reviews.llvm.org/D55052