[PATCH] D53693: [ASTImporter] Typedef import brings in the complete type

Wed Nov 28 10:34:46 PST 2018

shafik added a comment.

Apologies for my late comments.

================
Comment at: cfe/trunk/unittests/AST/ASTImporterTest.cpp:3780
+      typedefNameDecl(hasName("U")));
+  ASSERT_TRUE(ToD->getUnderlyingType()->isIncompleteType());
+
----------------
As far as I can tell `S<int>` is complete in `Code`, am I missing something? 

================
Comment at: cfe/trunk/unittests/AST/ASTImporterTest.cpp:3792
+      typedefNameDecl(hasName("U")));
+  ASSERT_FALSE(FromD->getUnderlyingType()->isIncompleteType());
+
----------------
Given my previous comment, I don't see why the addition code would change where `S<int>` was complete or not.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53693/new/

https://reviews.llvm.org/D53693