[PATCH] D54858: [OpenCL] Improve diagnostics for address spaces in template instantiation

Alexey Bader via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 28 08:09:25 PST 2018


bader added inline comments.


================
Comment at: lib/Sema/TreeTransform.h:5276
 
+    // Return type cann't be qualified with an address space.
+    if (ResultType.getAddressSpace() != LangAS::Default) {
----------------
"cann't" - typo?
cann't - > can't or cannot.


================
Comment at: test/CodeGenOpenCLCXX/template-address-spaces.cl:28
   sintptrgl.foo();
   //sintgl.foo();
 }
----------------
I think it should comment should also be removed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54858/new/

https://reviews.llvm.org/D54858





More information about the cfe-commits mailing list