[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

Ivan Donchevskii via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 28 05:37:33 PST 2018


yvvan added a comment.

I've realized that this patch covers too much stuff outside of clang and I have no idea how bad is to not memory map it.

"My hope is that we can get rid of this flag some day" - i'm not sure it's possible. For that we need some concept of user and system files in llvm similar to clang::SrcMgr::CharacteristicKind. But we can probably make an adapter for the MemoryBuffer in clang which will do the work at least in clang case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54995/new/

https://reviews.llvm.org/D54995





More information about the cfe-commits mailing list