[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

[Zachary Turner via cfe-commits]

I’m afraid this is going to be too severe a performance regression if we
change the default. So I don’t think this should be an LLVM-wide default
On Wed, Nov 28, 2018 at 1:38 AM Ivan Donchevskii via Phabricator <
reviews at reviews.llvm.org> wrote:

> yvvan added a comment.
>
> @ilya-biryukov
>
> I have the reported evidence but didn't yet have time to investigate
> myself.
> This is probably caused by our upgrade to Clang-7 which shows that we
> can't rely on the aimed fixes like the one I mention (D47460 <
> https://reviews.llvm.org/D47460>).
>
> Another option that I can suggest here is to remove all default isVolatile
> values at all, track all callers and specify the proper value in each case
> (ideally depending on the current flags). What do you think?
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D54995/new/
>
> https://reviews.llvm.org/D54995
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181128/91555ddc/attachment.html>