[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 27 14:23:50 PST 2018


Eugene.Zelenko added inline comments.


================
Comment at: clang-tidy/utils/LexerUtils.h:43
+  if (Start.isInvalid() || Start.isMacroID())
+    return SourceLocation();
   while (true) {
----------------
{} could returned instead.


================
Comment at: docs/ReleaseNotes.rst:180
   removal of the ``const`` keyword.
+>>>>>>> master
 
----------------
Merge artifact.


================
Comment at: docs/clang-tidy/checks/cppcoreguidelines-const-correctness.rst:6
+
+This check implements detection of local variables which could be declared as
+``const``, but are not. Declaring variables as ``const`` is required by many
----------------
Will be good idea to synchronize first statement with Release Notes.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54943/new/

https://reviews.llvm.org/D54943





More information about the cfe-commits mailing list