[clang-tools-extra] r347635 - [clangd] NFC: Prefer `isa<>` to `dyn_cast<>` to do the checking.

Henry Wong via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 26 20:27:00 PST 2018


Author: henrywong
Date: Mon Nov 26 20:27:00 2018
New Revision: 347635

URL: http://llvm.org/viewvc/llvm-project?rev=347635&view=rev
Log:
[clangd] NFC: Prefer `isa<>` to `dyn_cast<>` to do the checking.

Summary: Prefer `isa<>` to `dyn_cast<>` when there only need a checking.

Reviewers: ilya-biryukov, MaskRay

Reviewed By: ilya-biryukov, MaskRay

Subscribers: ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits, MTC

Differential Revision: https://reviews.llvm.org/D54878

Modified:
    clang-tools-extra/trunk/clangd/AST.cpp

Modified: clang-tools-extra/trunk/clangd/AST.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/AST.cpp?rev=347635&r1=347634&r2=347635&view=diff
==============================================================================
--- clang-tools-extra/trunk/clangd/AST.cpp (original)
+++ clang-tools-extra/trunk/clangd/AST.cpp Mon Nov 26 20:27:00 2018
@@ -95,11 +95,11 @@ std::string printName(const ASTContext &
     return Out.str();
   }
   // The name was empty, so present an anonymous entity.
-  if (llvm::dyn_cast<NamespaceDecl>(&ND))
+  if (isa<NamespaceDecl>(ND))
     return "(anonymous namespace)";
   if (auto *Cls = llvm::dyn_cast<RecordDecl>(&ND))
     return ("(anonymous " + Cls->getKindName() + ")").str();
-  if (llvm::dyn_cast<EnumDecl>(&ND))
+  if (isa<EnumDecl>(ND))
     return "(anonymous enum)";
   return "(anonymous)";
 }




More information about the cfe-commits mailing list