[PATCH] D54253: [OpenCL] Launch opencl-types.cl test only on x86

[Andrew Savonichev via Phabricator via cfe-commits]

asavonic added a comment.

>> FWIW, I'd vote for the first revision of this patch. From my
>> 
>>   understanding, the test verifies that libclang is able to parse OpenCL
>>   code correctly. It doesn't do anything specific to x86: target for x86 just
>>   happens to support a set of OpenCL extensions.
> 
> I am trying to understand what exactly does it bring into testing if the code doesn't have anything target specific in there?

It brings the architecture that does not support any OpenCL extension,
thus we check that types are "invalid".

> Tests are not entirely free, so we can't test absolutely everything.

Right. There is no big difference b/w these two revisions, so I'll leave
that to your discretion.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54253/new/

https://reviews.llvm.org/D54253