[PATCH] D52274: [clangd] Collect and store expected types in the index

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clangd/index/Index.cpp:118
+static void own(Symbol &S, UniqueStringSaver &Strings,
+                BumpPtrAllocator &Arena) {
   visitStrings(S, [&](StringRef &V) { V = Strings.save(V); });
----------------
sammccall wrote:
> why these changes?
Sorry, leftovers from the times we had arrays of sha hashes.


================
Comment at: clangd/index/SymbolCollector.h:80
+    /// Collect type information. Used to improve code completion ranking.
+    bool CollectTypes = true;
   };
----------------
sammccall wrote:
> Why make this an option? Is it expensive in time/size?
Was there for experiments. They're not expensive, removed it.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52274