[PATCH] D53696: [Haiku] Support __float128 for Haiku x86 and x86_64

Kristina Brooks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 22 15:29:10 PST 2018


kristina requested changes to this revision.
kristina added a comment.

In https://reviews.llvm.org/D53696#1305990, @kallisti5 wrote:

> Indeed. I agree the _GLIBCXX_USE_FLOAT128 is misplaced there.   That comes from config.h in libstdc++.  That's working around an issue in Haiku's build (libstdc++ is built by gcc, but then we try and use it with clang later)
>  I can remove that.
>
> Is the __FLOAT128__ desireable?


Sorry I was referring to `__FLOAT128__` being standard, the other define shouldn't be there IMO. But then again I'm not an expert on Haiku, `__FLOAT128__` seems fine to me, the other change looks more questionable, if anyone is familiar with Haiku internals, please chime in.


Repository:
  rC Clang

https://reviews.llvm.org/D53696





More information about the cfe-commits mailing list