[PATCH] D54798: Move the llvm lit test dependencies to clang-tools-extra.

Michał Górny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 21 09:06:18 PST 2018


mgorny added inline comments.


================
Comment at: test/CMakeLists.txt:76
+# Add lit test dependencies.
+set(llvm_utils_deps
+  FileCheck count not
----------------
Nitpicking a bit but I think it would be better to uppercase it for consistency.


================
Comment at: test/CMakeLists.txt:80
+foreach(dep ${llvm_utils_deps})
+  if (TARGET ${dep})
+    list(APPEND CLANGD_TEST_DEPS ${dep})
----------------
…and remove the space after `if`.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D54798





More information about the cfe-commits mailing list