[PATCH] D52713: Move llvm util dependencies from clang-tools-extra to add_lit_target.

Wed Nov 21 05:33:25 PST 2018

hokein added a subscriber: chapuni.
hokein added a comment.

Hi @mgorny, sorry for the trouble it might cause.

In https://reviews.llvm.org/D52713#1305164, @mgorny wrote:

> I would like to request reverting this. It's established standard within LLVM to explicitly specify the dependencies the particular test suite relies on.
>  This change causes the `-DLLVM_OCAML_OUT_OF_TREE=1` to start wrongly depending on additional test utility targets, causing building an unnecessary second copy of LLVMSupport.

I'm not an expert on this. It seems to me that `FileCheck, count, not` are reasonable dependencies to `lit` tests, and from what I se, lit tests of `llvm`, `clang` and `clang-tools-extra` are using these dep tools.
+ @chapuni, maybe you have ideas here? since you are the original author of the code r301762 <https://github.com/llvm-mirror/clang-tools-extra/commit/e305d959d02d6e65552200e3f7cb50b3f13840fe>.

Repository:
  rL LLVM

https://reviews.llvm.org/D52713